Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests on Windows #19777

Merged
merged 11 commits into from
Nov 15, 2022
Merged

Fix tests on Windows #19777

merged 11 commits into from
Nov 15, 2022

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Nov 8, 2022 •
edited by shilman
Loading

Issue: #19763 Some tests were commented out on windows because they were failing

What I did

Fixed some tests on Windows machines

How to test

  • Run yarn test on a Windows machine

@valentinpalkovic valentinpalkovic added linear build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Nov 8, 2022
@valentinpalkovic valentinpalkovic changed the title Fix tests on Windows Draft: Fix tests on Windows Nov 8, 2022
@valentinpalkovic valentinpalkovic removed linear ci:daily Run the CI jobs that normally run in the daily job. labels Nov 9, 2022
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-tests-on-windows branch 2 times, most recently from 8e470b7 to f3e8952 Compare November 9, 2022 10:23
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-tests-on-windows branch from eb81c45 to 99e24b4 Compare November 10, 2022 09:07
@valentinpalkovic valentinpalkovic changed the title Draft: Fix tests on Windows Fix tests on Windows Nov 10, 2022
@kasperpeulen kasperpeulen marked this pull request as draft November 10, 2022 14:45
@kasperpeulen kasperpeulen marked this pull request as ready for review November 10, 2022 14:45
@kasperpeulen kasperpeulen added ci:merged Run the CI jobs that normally run when merged. and removed ci:merged Run the CI jobs that normally run when merged. labels Nov 10, 2022
yannbf
yannbf reviewed Nov 11, 2022
View reviewed changes
code/lib/cli/src/helpers.ts Outdated Show resolved Hide resolved
yannbf
yannbf reviewed Nov 11, 2022
View reviewed changes
code/jest.config.js Outdated Show resolved Hide resolved
tmeasday
tmeasday approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @valentinpalkovic

@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-tests-on-windows branch 2 times, most recently from 78c3ddb to 36ede39 Compare November 14, 2022 08:20
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-tests-on-windows branch from 36ede39 to a6e483a Compare November 14, 2022 08:21
@shilman shilman mentioned this pull request Nov 14, 2022
Closed
@ndelangen ndelangen mentioned this pull request Nov 14, 2022
Merged
3 tasks
@IanVS
Copy link
Member

IanVS commented Nov 15, 2022

I see this has a few approvals, and I'm waiting on it to be merged for one of my PRs, so I'm going to go ahead and pull the trigger. Great work on this, @valentinpalkovic!

@IanVS IanVS merged commit 82dc644 into next Nov 15, 2022
@IanVS IanVS deleted the valentin/fix-tests-on-windows branch November 15, 2022 15:20
@shilman shilman mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf left review comments

@kasperpeulen kasperpeulen kasperpeulen left review comments

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday tmeasday approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valentinpalkovic @IanVS @tmeasday @kasperpeulen @yannbf @ndelangen